Skip to content

Cleanup Changelog Flow in WebUI#427

Merged
Martinski4GitHub merged 6 commits intodevfrom
ExtremeFiretop-Cleanup-Changelog
Mar 23, 2025
Merged

Cleanup Changelog Flow in WebUI#427
Martinski4GitHub merged 6 commits intodevfrom
ExtremeFiretop-Cleanup-Changelog

Conversation

@ExtremeFiretop
Copy link
Owner

Cleanup Changelog Function

Cleanup Changelog Function
@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Mar 21, 2025

New flow:

image
image

@Martinski4GitHub
Copy link
Collaborator

Martinski4GitHub commented Mar 22, 2025

New flow:

image

It looks good except that if users click too early on the "Close" button of the "Please wait" modal dialog (before the changelog is loaded), it seems to stop the loading process, and nothing happens.

IMO, the "Close" button in the dialog can be misleading and make users think that they can close the dialog at any point and continue to wait for the results.

@ExtremeFiretop
Copy link
Owner Author

ExtremeFiretop commented Mar 22, 2025

New flow:
image

It looks good except that if users click too early on the "Close" button of the "Please wait" modal dialog (before the changelog is loaded), it seems to stop the loading process, and nothing happens.

IMO, the "Close" button in the dialog can be misleading and make users think that they can close the dialog at any point and continue to wait for the results.

This is great feedback, I didn't even consider that.
I kept the cancel as a way to "back out" of waiting 10 seconds. But I can see the potential confusion. If they really don't want to wait they can refresh 🤣

@ExtremeFiretop
Copy link
Owner Author

What if I just change the wording to "Cancel"?

@Martinski4GitHub
Copy link
Collaborator

What if I just change the wording to "Cancel"?

Yeah, I think you would need to change the message to be clearer.
Something like:

Please wait and allow up to 10 seconds for the changelog to load.
Click on "Cancel" button to stop and exit this dialog.

@ExtremeFiretop
Copy link
Owner Author

What if I just change the wording to "Cancel"?

Yeah, I think you would need to change the message to be clearer. Something like:

Please wait and allow up to 10 seconds for the changelog to load.
Click on "Cancel" button to stop and exit this dialog.

Consider it done. I'll modify the button while it's loading to say cancel, and the text as well.
Please stand by, I'll have it done in a little bit.

@Martinski4GitHub
Copy link
Collaborator

@ExtremeFiretop,

My wife wants to watch a movie, so I'm getting offline now.
We'll continue this tomorrow evening, so there's no rush.

Have a good night, bud!!! Talk to you tomorrow.

@ExtremeFiretop
Copy link
Owner Author

@ExtremeFiretop,

My wife wants to watch a movie, so I'm getting offline now. We'll continue this tomorrow evening, so there's no rush.

Have a good night, bud!!! Talk to you tomorrow.

Enjoy!

@ExtremeFiretop
Copy link
Owner Author

Done! :)

@Martinski4GitHub
Copy link
Collaborator

Done! :)

Nice!! Now the messaging and the flow are much clearer and smoother.

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@Martinski4GitHub Martinski4GitHub merged commit 959a1c3 into dev Mar 23, 2025
1 check passed
@ExtremeFiretop ExtremeFiretop changed the title Cleanup Changelog Function Cleanup Changelog Flow in WebUI Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants